Move autolock timer #3743
Open
Move autolock timer #3743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix SharedSelect trigger z-index Fix OnboardingDerivationPathSelect width
Shadowfiend
reviewed
May 4, 2024
There was a problem hiding this comment.
Not quite ready to merge here as I'm worried that the z-index will have unintended side-effects. In particular, this z-index was introduced in 8cf22e4, which handled the slippage tolerance dropdown for swaps—wondering if removing it creates problems there.
| @@ -167,7 +167,6 @@ export default function SharedSelect(props: Props): ReactElement { | |||
|
|
|||
| .button { | |||
| position: relative; | |||
| z-index: 1; | |||
There was a problem hiding this comment.
Worried that this misses a place where the z-index does matter. Are we sure it doesn't?
There was a problem hiding this comment.
is being used in 2 places as of now:
<Settings />, where it actually overflows another one, hence the removal ofz-index(screenshot 2)<OnboardingDerivationPathSelect />, wherez-indexdoes not affect anything.
IMO, this select trigger is a button and there is no reason for it to have an abnormal z-index, especially if it's higher than select menu.
| @@ -180,6 +180,7 @@ export default function ImportSeed(props: Props): ReactElement { | |||
| margin-top: 16px; | |||
| } | |||
| .select_wrapper { | |||
| width: 100%; | |||
| @@ -412,6 +412,7 @@ export default function Settings(): ReactElement { | |||
| FeatureFlags.SUPPORT_ACHIEVEMENTS_BANNER, | |||
| notificationBanner, | |||
| ), | |||
| autoLockSettings, | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3572
What
Move auto-lock timer
Fix SharedSelect trigger z-index
Fix OnboardingDerivationPathSelect width
