ls - Accept and process a list of dirs #735
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jehadbaeth
commented
Jul 6, 2020
| else: | ||
| for directory in where: | ||
| rc.append(list_dir(directory)) | ||
| return min(rc) |
There was a problem hiding this comment.
return success if at least one operation was a success.
There was a problem hiding this comment.
Might be better to have the above comment in the code rather than a long-lost PR
jehadbaeth
commented
Jul 6, 2020
| url += "?t=json" | ||
| resp = do_http("GET", url) | ||
| if resp.status == 404: | ||
| print("%s: No such file or directory" % directory, file=stderr) |
There was a problem hiding this comment.
added dir/filename in the error.
jehadbaeth
force-pushed
the
bug/2448
branch
6 times, most recently
from
dc54b99
to
6d3854c
Compare
Codecov Report
@@ Coverage Diff @@
## master #735 +/- ##
=======================================
- Coverage 92% 92% -0%
=======================================
Files 151 157 +6
Lines 27031 27491 +460
Branches 4044 4114 +70
=======================================
+ Hits 24955 25287 +332
- Misses 1432 1538 +106
- Partials 644 666 +22
Continue to review full report at Codecov.
|
jehadbaeth
force-pushed
the
bug/2448
branch
4 times, most recently
from
8c69b1f
to
dae5e5b
Compare
added 2 commits
February 8, 2021 14:42
…e dir returns a valid value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a fix for tahoe ls $THING $OTHERTHING` doesn't work
sample input/output