Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove more usage of "future" #1362

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

remove more usage of "future" #1362

wants to merge 2 commits into from

Conversation

a-detiste
Copy link
Contributor

No description provided.

meejah
meejah requested changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@meejah meejah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good, but there's still unicode-weirdness with listdir right? (see inline)

src/allmydata/util/encodingutil.py Show resolved Hide resolved
@coveralls
Copy link
Collaborator

coveralls commented Mar 11, 2024 •
edited

Coverage Status

coverage: 95.456% (+0.08%) from 95.379%
when pulling 1504bec on a-detiste:remove-future
into 432e041 on tahoe-lafs:master.

@a-detiste
Copy link
Contributor Author

Is it OK?

@meejah
Copy link
Contributor

meejah commented Apr 24, 2024

Sorry I was away last week, am back now and will take a look soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meejah meejah meejah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@a-detiste @coveralls @meejah