Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove old Python2 __future__ statements #1358

Merged
merged 3 commits into from Feb 21, 2024
Merged

remove old Python2 __future__ statements #1358

merged 3 commits into from Feb 21, 2024

Conversation

a-detiste
Copy link
Contributor

This is the easiest part to review from my huge previous PR.

from __future__ import annotations stays of course.

@coveralls
Copy link
Collaborator

coveralls commented Feb 15, 2024 •
edited

Coverage Status

coverage: 94.691%. first build
when pulling 43c9d04 on a-detiste:remove-future
into 684c7bb on tahoe-lafs:master.

@a-detiste
Copy link
Contributor Author

This one is ready

@itamarst
Copy link
Collaborator

Just need to run CI so things pass.

meejah
meejah approved these changes Feb 20, 2024
View reviewed changes
Copy link
Contributor

@meejah meejah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
(love lots of code deletions :)

@itamarst itamarst merged commit 3afd2dc into tahoe-lafs:master Feb 21, 2024
30 of 31 checks passed
@a-detiste a-detiste deleted the remove-future branch February 21, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meejah meejah meejah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@a-detiste @coveralls @itamarst @meejah @pythonspeed