Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No more blocking, part 2 #1350

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Conversation

itamarst
Copy link
Collaborator

@itamarst itamarst commented Dec 8, 2023

Fixes https://tahoe-lafs.org/trac/tahoe-lafs/ticket/4072

There are more for future branches.

@coveralls
Copy link
Collaborator

coveralls commented Dec 8, 2023

Coverage Status

coverage: 94.722%. first build
when pulling 0f596fb on 4072-no-more-blocking-part-2
into 3afd2dc on master.

@itamarst
Copy link
Collaborator Author

The test failure is consistent but also I can't figure out why it's happening.

@itamarst
Copy link
Collaborator Author

itamarst commented Jan 4, 2024

I guess tests failures are not happening consistently? Since CI is green now. I guess I'll rerun again and see if they return.

@itamarst
Copy link
Collaborator Author

itamarst commented Jan 4, 2024

Now it's got 3 different failures, one of them the dirty reactor one we've seen a lot. Ugh.

Copy link
Contributor

@meejah meejah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants