Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

benchmark improvements #1340

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

benchmark improvements #1340

wants to merge 11 commits into from

Conversation

meejah
Copy link
Contributor

@meejah meejah commented Oct 4, 2023

Some minor benchmark improvements while looking at them, including a README

Note this is stacked on top of 4065 / #1339

@coveralls
Copy link
Collaborator

coveralls commented Oct 4, 2023 •
edited

Coverage Status

coverage: 94.585% (-0.01%) from 94.595%
when pulling b5d4a71 on meejah:4069-benchmark-improvements
into c98be85 on tahoe-lafs:master.

@itamarst itamarst changed the base branch from master to 517.add-client-plugin-config.1 October 16, 2023 17:16
@itamarst itamarst changed the base branch from 517.add-client-plugin-config.1 to master October 16, 2023 17:16
exarkun
exarkun requested changes Nov 20, 2023
View reviewed changes
Copy link
Member

@exarkun exarkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Some comments inline. I also wrote a nix runner for the benchmarks (otherwise it's too hard to run them on nixos 🙂 ) which I'll submit separately.

benchmarks/README.rst Outdated Show resolved Hide resolved
benchmarks/README.rst Outdated Show resolved Hide resolved
benchmarks/conftest.py Outdated Show resolved Hide resolved
benchmarks/conftest.py Outdated Show resolved Hide resolved
exarkun
exarkun reviewed Nov 20, 2023
View reviewed changes
benchmarks/conftest.py Outdated Show resolved Hide resolved
@meejah meejah requested a review from exarkun November 20, 2023 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@exarkun exarkun Awaiting requested review from exarkun

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@meejah @coveralls @exarkun