3972.untyped defs in utils #1259
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fault None but cannot assign Optional[int]
danielzwlee
force-pushed
the
3972.untyped-defs
branch
from
d7bed1a
to
96ec232
Compare
src/allmydata/util/dictutil.py
Outdated
| @@ -28,7 +29,7 @@ class AuxValueDict(dict): | |||
| values: the main value, and an auxilliary one. Setting the main value | |||
| (with the usual d[key]=value) clears the auxvalue. You can set both main | |||
| and auxvalue at the same time, and can retrieve the values separately. | |||
|
|
|||
| s | |||
src/allmydata/util/idlib.py
Outdated
| @@ -14,15 +14,15 @@ | |||
| from foolscap import base32 | |||
|
|
|||
|
|
|||
| def nodeid_b2a(nodeid): | |||
| def nodeid_b2a(nodeid: str) -> str: | |||
There was a problem hiding this comment.
Would nodeid make a good type?
There was a problem hiding this comment.
What library would that be from? I think nodeid should also be bytes right? I understand we want stricter type annotations and I think bytes might be more appropriate, since the function changes bytes to ASCII.
…olscpa.referenceable.RemoteReference to add class variable rref.version which goes against static typing
…olscpa.referenceable.RemoteReference to add class variable rref.version which goes against static typing
danielzwlee
force-pushed
the
3972.untyped-defs
branch
from
a362403
to
3b8ba8b
Compare
danielzwlee
force-pushed
the
3972.untyped-defs
branch
from
574e605
to
ef4e347
Compare
danielzwlee
force-pushed
the
3972.untyped-defs
branch
from
d348440
to
29cefe6
Compare
danielzwlee
force-pushed
the
3972.untyped-defs
branch
from
e6acbaf
to
e0362dc
Compare
danielzwlee
force-pushed
the
3972.untyped-defs
branch
4 times, most recently
from
448fde6
to
3ff30c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket is https://tahoe-lafs.org/trac/tahoe-lafs/ticket/3972,
The scope of this ticket was initially very big and thus I will be focusing on the untyped-defs in the util files first. Since these files seem to be the few most used files and I think type annotations will help greatly in understanding what they do and help catch bugs.
Changes:
Added type annotations to util files.