Merge pull request #1360 from meejah/4091.fragile

Fix fragile unit-test (4091) Fixes ticket:4091
tahoe-lafs · Feb 27, 2024 · a23a97d · a23a97d
2 parents 3afd2dc + 825e42c
commit a23a97d
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/newsfragments/4091.minor b/newsfragments/4091.minor
diff --git a/src/allmydata/test/test_humanreadable.py b/src/allmydata/test/test_humanreadable.py
@@ -27,7 +27,8 @@ def __init__(self):
 class HumanReadable(unittest.TestCase):
     def test_repr(self):
         hr = humanreadable.hr
-        self.failUnlessEqual(hr(foo), "<foo() at test_humanreadable.py:20>")
+        # we match on regex so this test isn't fragile about line-numbers
+        self.assertRegex(hr(foo), r"<foo\(\) at test_humanreadable.py:\d+>")
         self.failUnlessEqual(hr(self.test_repr),
                              "<bound method HumanReadable.test_repr of <allmydata.test.test_humanreadable.HumanReadable testMethod=test_repr>>")
         self.failUnlessEqual(hr(long(1)), "1")