Show the user an error message when no tables were extracted #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mcharters Do you recall what PDF you used to test this bug and your solution? I'd like to take a look at the proposed solution. Thanks! |
|
Hmm, sorry - this was a while ago and I have no idea what PDF it might have been. If I happen to run across it I can let you know. |
|
@mcharters: Fair enough and thanks anyways :) I think I might know where to find a script that replicated this issue... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you have a table that returns an empty array from the "guess" extraction method, there's an undefined value error and the UI spins.
This change lets the user know that the extraction didn't work.
I don't know if the debug info/request for bugs should be shown here, but I've kept it around for now.