Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide container images #1177

Merged
merged 2 commits into from Apr 10, 2024
Merged

Provide container images #1177

merged 2 commits into from Apr 10, 2024

Conversation

0x2b3bfa0
Copy link
Contributor

@0x2b3bfa0 0x2b3bfa0 commented Oct 4, 2023

After merging this pull request and publishing a new release, this should work:

docker run --rm --publish 9292:9292 ghcr.io/tabulapdf/tabula

The service will be available on http://localhost:9292

@jeremybmerrill
Copy link
Member

Thanks! I don't really know how to evaluate this, but at least superficially this looks good to me. @jazzido ? @mtigas ?

@mtigas
Copy link
Member

mtigas commented Nov 15, 2023

It's been quite a few months since I've messed with a github action, but it appears fine to me.

I'm cool with this merging in. And then I guess TBD when we'd be able to tag, build, and push another release to make this actually usable -- since that's another thing we haven't done in a few years. But merging would at least queue us up for that.

@0x2b3bfa0
Copy link
Contributor Author

@mtigas, feel free to merge this; I don't have permission to do so.

@jazzido jazzido merged commit f4f15e8 into tabulapdf:master Apr 10, 2024
@0x2b3bfa0 0x2b3bfa0 deleted the patch-1 branch April 10, 2024 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants