Skip to content
This repository has been archived by the owner on Jan 21, 2024. It is now read-only.

Catch unexpected values in array #63

Merged
merged 2 commits into from Jul 16, 2018
Merged

Catch unexpected values in array #63

merged 2 commits into from Jul 16, 2018

Conversation

lesliedoherty
Copy link
Contributor

As a result of a brief linkedin bug where the array prototype was modified, this simple solutions offers better defensive detection of values passed in the config by checking that the value has its own property associated with it.

screenshot 2018-07-02 15 13 57

@lesliedoherty
Copy link
Contributor Author

Note regarding failing tests. I've opened an issue: #64

@iamEAP
Copy link
Contributor

iamEAP commented Jul 3, 2018

Thanks for the issue on the test fails @lesliedoherty. I can repro them locally too, but they only occur on the git1 and git2 versions of jQuery.

Maybe we stop testing against "dev" branches for jQuery, but at least update the versions we test against? e.g.

Go from

['1.3.2', '1.4.4', '1.5.2', '1.6.4', '1.7.2', '1.8.3', '1.9.1', '1.10.2', '1.11.3', '1.12.0', 'git1', '2.0.3', '2.1.4', '2.2.0', 'git2']

...to...

['1.3.2', '1.4.4', '1.5.2', '1.6.4', '1.7.2', '1.8.3', '1.9.1', '1.10.2', '1.11.3', '1.12.4', '2.0.3', '2.1.4', '2.2.4', '3.0.0', '3.1.1', '3.2.1']

In Gruntfile.js?

Copy link
Contributor

@angrytoast angrytoast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changeset looks good. Would recommend going with @iamEAP's comment in #63 (comment)

@iamEAP
Copy link
Contributor

iamEAP commented Jul 16, 2018

Thanks all. I updated the jQuery test targets. Merging to master, then picking the change into branches where it applies and releasing updates.

@iamEAP iamEAP merged commit 3c835b0 into master Jul 16, 2018
@iamEAP iamEAP deleted the patch branch July 16, 2018 16:59
@iamEAP iamEAP mentioned this pull request Jul 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants