Initial Implementation of Global for Prefix Benefits #4185
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the new feature?
#4184
Why should this be part of tModLoader?
To increase cross-mod compatibility and 'vanilla'-like behavior.
Are there alternative designs?
Could implement new GlobalPrefix instead of adding another hook to GlobalItem class
For one hook, I'm not sure it adds significant value to break out a net new global. There isn't exactly a 'Prefix' entity to apply this to in 'normal' fashion. And all the other 'Update Accessory' logic is already in GlobalItem.
On the flip side, it would be significantly more consistent with other hook usage & I assume more performant.
Sample usage for the new feature