Make HitInfo and HurtInfo read/init only #4151
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the new feature?
NPC.HitInfo
andPlayer.HurtInfo
are nowreadonly
and haveget; init
properties.Why should this be part of tModLoader?
Are there alternative designs?
Make the hook parameters
in
instead. This would be just as breaking, and not carry through to user's own non-hook methods. The dotnet guidelines also recommend making a structreadonly
if it's going to be used within
where possible (though this is a performance detail that isn't too relevant to us).Sample usage for the new feature
ExampleMod updates
None required