-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tModCodeAssist rewrite #4099
Open
BasicallyIAmFox
wants to merge
46
commits into
tModLoader:1.4.4
Choose a base branch
from
BasicallyIAmFox:tmodcodeassist
base: 1.4.4
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
tModCodeAssist rewrite #4099
+3,600
−99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How tModPorter and tModBuildTasks even get there?
…ModLoader into tmodcodeassist
Mirsario
requested changes
Mar 18, 2024
patches/tModLoader/Terraria/ModLoader/Annotations/AssociatedIdTypeAttribute.cs
Outdated
Show resolved
Hide resolved
tModCodeAssist/tModCodeAssist.CodeFixes/tModCodeAssist.CodeFixes.csproj
Outdated
Show resolved
Hide resolved
tModCodeAssist/tModCodeAssist.Tests/CodeFixers/ChangeMagicNumberToIDUnitTest.cs
Outdated
Show resolved
Hide resolved
tModCodeAssist/tModCodeAssist.Tests/CodeFixers/SimplifyUnifiedRandomUnitTest.cs
Outdated
Show resolved
Hide resolved
tModCodeAssist/tModCodeAssist/ChangeMagicNumberToID/Data/ChangeMagicNumberToID.Data.json
Outdated
Show resolved
Hide resolved
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the new feature?
Reworked analyzers for tML.
tModLoader.targets
Why should this be part of tModLoader?
Having tModCodeAssist in the tModLoader repository is much better than having it separately and publishing it as a nuget package because we don't have to consider supporting 1.3, 1.4.3, and 1.4.4 at the same time in one codebase. New analyzer rules will also help new modders port vanilla code and can help them simplify their own code.
Are there alternative designs?
Sample usage for the new feature
ExampleMod updates
N/A
TODO
rand
simplify ruleItemID
,NPCID
,ProjectileID
, etch)