Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor Decraft Fixes #3993

Open
wants to merge 5 commits into
base: 1.4.4
Choose a base branch
from
Open

Minor Decraft Fixes #3993

wants to merge 5 commits into from

Conversation

Kogsey
Copy link
Contributor

@Kogsey Kogsey commented Dec 27, 2023

Ref #3991 and #3722
Doing this because shimmer API is waiting for 1.4.5 and bug needs fix.

What is the bug?

  1. Recipe.notDecraftable is not readable to mods
  2. Decrafted bottled stuff + other similar mod effects don't have random 1/3 loss applied
  3. Non-stackable items cannot be unstacked when shimmered from stacked items

How did you fix the bug?

  1. New property Recipe.DecraftDisabled Wraps Recipe.notDecraftable bc notDecraftable is vanilla, would be a large patch to replace, and var name DecraftDisabled > notDecraftable
  2. Obsoleted
  3. Non-stackables now spawn as separate items

Are there alternatives to your fix?

  1. N/A
  2. Previously discussed.
  3. N/A

@Chicken-Bones
Copy link
Member

Despite the code for consumption being almost entirely reusable, it certainly takes some wrapping your head around.

I think I favor your proposed alternative for #2. Rather than ConsumeItemCallback the decraft version could be called DecraftItemCallback or DecraftIngredientCallback.

You'll need to pose the question in #collaborators.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants