Make ODEModel a subclass of CallableNumericalModel #288
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes ODEModel a subclass of CallableNumericalModel, which magically enables using constraints with ODEModels.
In addition, to preserve existing behaviour, the finite_difference method is moved to CallableModel (everything we can call we can approximate the Jacobian for). This in turn means we now always generate a covariance matrix. Very shiny. The downside is I had to touch everything that made decisions on whether something had a jacobian/hessian. All
hasattr(x, 'eval_jacobian/hessian')
were changed to appropriateisinstance(x, (Gradient|Hessian)(Model|Objective)
to avoid using the finite difference method during minimization, for which it's way too slow.As a final nit, remove setting of bounds on fixed parameters, since this messes with minimizer selection and doesn't add value.
Fixes #282