Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically replace \n with <br> #772

Merged
merged 1 commit into from Dec 14, 2017
Merged

Automatically replace \n with <br> #772

merged 1 commit into from Dec 14, 2017

Conversation

lionralfs
Copy link
Collaborator

This closes #740 and #770 as it transforms \n to <br> tags when used like this:

swal('Hello\nWorld');

Implementation might look a little funky, but I wanted to stay away from .innerHTML.

Also: tests 馃榿

@FALL1N1 FALL1N1 mentioned this pull request Nov 26, 2017
Closed
@t4t5
Copy link
Owner

t4t5 commented Dec 14, 2017

Awesome. And you even added a test 鉂わ笍

@t4t5 t4t5 merged commit cc6dcdd into t4t5:master Dec 14, 2017
@lionralfs lionralfs deleted the feature/nl2br branch January 7, 2019 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

How to add multiple text rows?
2 participants
@lionralfs @t4t5