Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project might be malicious #748

Open
daftspunk opened this issue Oct 14, 2017 · 4 comments
Open

Project might be malicious #748

daftspunk opened this issue Oct 14, 2017 · 4 comments

Comments

@daftspunk
Copy link

Following from #733 which appears to be going off topic. This web project appears to engage in bad practise, forcing users to install software to their local environment to use it (npm), otherwise forcing them to use compiled and obfuscated code which cannot be verified.

I request that you include a simple method to obtain unminified source files to prove they are not malicious before use.

@infostreams
Copy link

Perhaps you can use subresource integrity for your particular use case? Support is not terrible.

@gtmadev
Copy link

gtmadev commented Nov 11, 2017

This is also a show-stopper issue for me. I package up my js and css into several bundles. Right now, there is no uniminified js code that I can pass to my gulp script. And there is NO way I am going to just blindly dump obfuscated JavaScript into my product's code.

If there is unminified code that can be reviewed, I can use this new version.

@ndcisiv
Copy link

ndcisiv commented Dec 4, 2017

There is also SweetAlert2, which does have an un-minified version available. That could save some troubles. Works great.
https://github.com/limonte/sweetalert2/releases

@zenflow
Copy link

zenflow commented Jan 13, 2018

@daftspunk Thanks for separating this issue from the others in #733

I think this issue may be invalid...

I need unminified source files so I can prove they are not malicious.

This web project appears to engage in bad practise, forcing users to install software to their local environment to use it (npm), otherwise forcing them to use compiled and obfuscated code which cannot be verified.

We should create a new issue or PR "Provide unobfuscated build in package distribution". If that is rejected for no good reason, then I might be suspicious that the author is doing something malicious.

If it's accepted, then you can access the dist files, of any version, minified or unminified, via unpkg.com


Keeping build/dist files in source-control is really going against widespread convention and causes pain with Git tooling. Check out the setup of the React project for instance. It is extremely standard, in that dist files are included in the package distribution on npm (check the umd folder) and not included in the source-code repository on Github.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants