Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub releases missing built files ("./dist" folder) #1606

Closed
david-peter-smith opened this issue May 31, 2019 · 2 comments · Fixed by #1610
Closed

GitHub releases missing built files ("./dist" folder) #1606

david-peter-smith opened this issue May 31, 2019 · 2 comments · Fixed by #1610

Comments

@david-peter-smith
Copy link

Current behavior

The current release v8.11.7 is missing the built files ("./dist" folder) that contains the final production code.

Expected behavior

The final built files should be included in tagged full releases for the greatest accessibility of users. Many people do not use CDNs or Package Managers to fetch libraries which is why a ./dist folder is typically present for all releases. Looking at the documentation of this awesome library the dist folder is present within the Readme documentation itself under usage, so it's exclusion can confuse people in addition to making it harder for them to get and use the library.

Live demo

https://github.com/sweetalert2/sweetalert2/archive/v8.11.7.zip

@limonte limonte changed the title Releases missing built files ("./dist" folder) in version control GitHub releases missing built files ("./dist" folder) Jun 3, 2019
@limonte limonte reopened this Jun 7, 2019
@limonte
Copy link
Member

limonte commented Jun 8, 2019

If for some reason you can't use package managers or CDN, please do this:

Step 1: follow the CDN link from the installation guide:

image

Step 2: click the "Download" button

image

@limonte
Copy link
Member

limonte commented Apr 16, 2021

🎉 All files from the dist folder are available on GitHub releases starting from https://github.com/sweetalert2/sweetalert2/releases/tag/v10.16.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants