Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update drizzle config to be up to date with the latest version #1881

Merged
merged 13 commits into from May 10, 2024

Conversation

gcjbr
Copy link
Contributor

@gcjbr gcjbr commented May 10, 2024

Closes #

βœ… Checklist

  • [x ] I have followed every step in the contributing guide (updated 2022-10-06).
  • The PR title follows the convention we established conventional-commit
  • I performed a functional test on my final commit

Changelog

_ drizzle-config-sqlite.ts, drizzle-config-postgres.ts and drizzle-config-mysql.ts were changed to adhere to Drizzle's format


Screenshots

Screenshot 2024-05-10 at 15 08 25 Screenshot 2024-05-10 at 15 08 32

While running Drizzle Studio we are always asked to update it to the latest version, or it won't show the UI. After tha last update, it's finding an error with the current template configs.

This fixes it.

πŸ’―

Copy link

changeset-bot bot commented May 10, 2024

πŸ¦‹ Changeset detected

Latest commit: 7e765e7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-t3-app Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented May 10, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
create-t3-app βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback May 10, 2024 7:53pm

Copy link

vercel bot commented May 10, 2024

@gcjbr is attempting to deploy a commit to the t3-oss Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Member

@juliusmarminge juliusmarminge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you bump the versions in dependencyVersionMap as well just so that it will always pull ^0.21 no matter what package manager? Thanks!

@gcjbr
Copy link
Contributor Author

gcjbr commented May 10, 2024

Can you bump the versions in dependencyVersionMap as well just so that it will always pull ^0.21 no matter what package manager? Thanks!

Done

@juliusmarminge
Copy link
Member

CI failing

@juliusmarminge
Copy link
Member

@gcjbr
Copy link
Contributor Author

gcjbr commented May 10, 2024

CI failing

I've bumped the dependencyVersionMap. I see the linter is failing, it's failing locally on the main branch as well, on the same places it's failing here.

Weird πŸ‘οΈ

@juliusmarminge
Copy link
Member

juliusmarminge commented May 10, 2024

idk why the hell shiki is overriding global Response type...

CleanShot 2024-05-10 at 21 21 24

cba to dig in - just added some casts

@gcjbr
Copy link
Contributor Author

gcjbr commented May 10, 2024

idk why the hell shiki is overriding global Response type...

CleanShot 2024-05-10 at 21 21 24

cba to dig in - just added some casts

Right?

Weirdest to me is the unchanged code is also not passing the linting. How the heel did it pass linting on main in the first place? πŸ₯Έ

@juliusmarminge
Copy link
Member

okay it was the big lockfile diff that was causing the issues

i reverted the lock file changes and resynced it and thing's are back to normal

@juliusmarminge
Copy link
Member

idk what pnpm version you're on but you had caused like 6k lines of diff in the lockfile which i reverted b0e6dfe

@juliusmarminge
Copy link
Member

Now we have some failing CI again (that's actually cause of the change)
CleanShot 2024-05-10 at 21 27 01

Can you fix it up so it's passing?

@gcjbr
Copy link
Contributor Author

gcjbr commented May 10, 2024

idk what pnpm version you're on but you had caused like 6k lines of diff in the lockfile which i reverted b0e6dfe

pnpm -v
8.6.5

Nice catch, thanks!

I'll fix the other test

@gcjbr
Copy link
Contributor Author

gcjbr commented May 10, 2024

@juliusmarminge , done!

Can you tell me your PNPM version, btw?

Just so I don't create a mess in the future

@juliusmarminge
Copy link
Member

I use corepack so it matches whatever is in package.json#packageManager

@juliusmarminge juliusmarminge added this pull request to the merge queue May 10, 2024
Merged via the queue into t3-oss:main with commit 9e5e7d0 May 10, 2024
266 of 267 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants