Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: replace youtube video with new one #1825

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

OmriOn
Copy link

@OmriOn OmriOn commented Apr 17, 2024

Closes #

βœ… Checklist

  • I have followed every step in the contributing guide (updated 2022-10-06).
  • The PR title follows the convention we established conventional-commit
  • I performed a functional test on my final commit

Changelog

Switched the youtube embed on the "Introduction" page from this video to this one.


Screenshots

image

πŸ’―

Copy link

changeset-bot bot commented Apr 17, 2024

⚠️ No Changeset found

Latest commit: dc7ac7c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Apr 17, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
create-t3-app βœ… Ready (Inspect) Visit Preview πŸ’¬ 1 unresolved
βœ… 1 resolved
Apr 17, 2024 1:36pm

Copy link

vercel bot commented Apr 17, 2024

@OmriOn is attempting to deploy a commit to the t3-oss Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Member

@juliusmarminge juliusmarminge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you'd like we could include both with a toggle for pages vs app router. All our docs are still referencing to pages router so might be a bit misleading to only have a tutorial on app router

@OmriOn
Copy link
Author

OmriOn commented Apr 20, 2024

If you'd like we could include both with a toggle for pages vs app router. All our docs are still referencing to pages router so might be a bit misleading to only have a tutorial on app router

i wont be able to in the next week or so but ill get to it after

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
πŸ“š documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants