Introduce Valgrind to the CI pipeline #369
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrybear327
force-pushed
the
ci/valgrind
branch
from
f6a5926
to
85b9001
Compare
|
To merge this pull request, all the memory-related leaks need to be addressed first. Currently, based on my initial testing, when disabling SDL and JIT, no memory leaks are found. When enabling JIT, there will be plenty of leaks. |
henrybear327
force-pushed
the
ci/valgrind
branch
from
85b9001
to
7069c80
Compare
The static analyzer alone can't catch all the runtime issues. In this commit, the dynamic analysis tool Valgrind is added to the CI pipeline. ENABLE_SDL is set to 0, in order to reduce noise caused by the external libraries. Reference: - https://valgrind.org/docs/manual/quick-start.html - https://linux.die.net/man/1/gcc
henrybear327
force-pushed
the
ci/valgrind
branch
from
7069c80
to
485d987
Compare
visitorckw
reviewed
Mar 1, 2024
| @@ -11,6 +11,14 @@ CFLAGS = -std=gnu99 -O2 -Wall -Wextra | |||
| CFLAGS += -Wno-unused-label | |||
| CFLAGS += -include src/common.h | |||
|
|
|||
| ENABLE_VALGRIND ?= 0 | |||
| ifeq ("$(ENABLE_UBSAN)", "1") | |||
There was a problem hiding this comment.
It looks like a typo to me. Did you mean 'ENABLE_VALGRIND' instead of 'ENABLE_UBSAN'?
visitorckw
reviewed
Mar 1, 2024
| # according to gcc's man page: "If you use multiple -O options, with or without level numbers, the last such option is the one that is effective." | ||
| # In order to use Valgrind, we need to compile with -g | ||
| CFLAGS += -g | ||
| LDFLAGS += -g |
There was a problem hiding this comment.
The '-g' flag is not specifically designed for valgrind. Have you considered using a different name such as ENABLE_DEBUG instead of ENABLE_VALGRIND?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The static analyzer alone can't catch all the runtime issues. In this commit, the dynamic analysis tool Valgrind is added to the CI pipeline.
ENABLE_SDL is set to 0, in order to reduce noise caused by the external
libraries.
Reference: