vinput: Fix multiple issue #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove redundant memset calls as memory allocated with kzalloc is already zeroed due to the presence of the __GFP_ZERO gfp flag.
When kzalloc fails to allocate memory and returns NULL, it leads to a NULL pointer dereference error later on. Add a check for the return value of kzalloc. When kzalloc fails to allocate memory, it prints an error message and returns ERR_PTR(-ENOMEM).
When raw_copy_to_user() failed in vinput_read(), the function would set 'count' to -EFAULT and then subtract EFAULT from '*offset'. However, modifying '*offset' on raw_copy_to_user() failure was incorrect. Fix this behavior by changing count = -EFAULT to return -EFAULT.
|
Can you check #52 ? |
|
Looks good to me. |
jserv
changed the title
I can spend some time understanding try_module_get and put_module_get and try to resolve this issue. |
|
Thank @visitorckw for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix multiple issues for vinput module: