s3: GCS compatibility #4956
Merged
s3: GCS compatibility #4956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orymate
commented
May 9, 2024
Google Cloud Storage's implementation of the S3 API responds the following error to a requests like "GET /bucket?uploads&prefix=p&key-marker=&upload-id-marker=": <Error> <Code>InvalidArgument</Code> <Message>Invalid argument.</Message> <Details>Invalid upload ID marker: </Details> </Error> Specify these query parameters only in subsequent requests after we get a truncated response. Signed-off-by: Mate Ory <mate.ory@axoflow.com>
orymate
force-pushed
the
fix-s3-gcp-list-multipart-uploads
branch
from
edc8126
to
1d9061b
Compare
alltilla
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Google Cloud Storage's implementation of the S3 API responds the following error to requests like
GET /bucket?uploads&prefix=p&key-marker=&upload-id-marker=:The changed code specifies these query parameters only in subsequent requests after we get a truncated response.
The boto3
Client.list_multipart_uploads()method doesn't accept None arguments, so this was the most readable solution that I could come up with.