Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement rfc6587 auto detection #4814

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Implement rfc6587 auto detection #4814

wants to merge 6 commits into from

Conversation

bazsi
Copy link
Collaborator

@bazsi bazsi commented Feb 3, 2024 •
edited

This is a pretty common misconfiguration that should be handled automatically.

Open questions were resolved this way:

  • syslog(transport(tcp/tls)) will default to enable framing detection
  • if you want to require framing transport(force-framed) will do that, but I doubt anyone needs that, so let's not document it.
  • auto is only the name of the class, it's not user visible anymore.
  • testcases are added

@kira-syslogng
Copy link
Contributor

Build FAILURE

@bazsi bazsi force-pushed the implement-rfc6587-auto-detection branch from b9e8d15 to e04b4ba Compare February 3, 2024 15:42
@bazsi
Copy link
Collaborator Author

bazsi commented Feb 3, 2024

#4792

MrAnno
MrAnno reviewed Feb 3, 2024
View reviewed changes
Copy link
Collaborator

@MrAnno MrAnno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the name auto is good, we just need to clarify that this is for "syslog" protos.

What do you think about LogProtoAutoSyslogServer?

lib/logproto/logproto-auto-server.c Outdated Show resolved Hide resolved
@bazsi bazsi force-pushed the implement-rfc6587-auto-detection branch from e04b4ba to 8c1d4a2 Compare February 4, 2024 12:21
@kira-syslogng
Copy link
Contributor

Build FAILURE

@bazsi bazsi force-pushed the implement-rfc6587-auto-detection branch from 8c1d4a2 to 81d057f Compare February 4, 2024 13:23
@kira-syslogng
Copy link
Contributor

Build FAILURE

@bazsi bazsi force-pushed the implement-rfc6587-auto-detection branch 2 times, most recently from 75a230b to 67c9f4d Compare February 4, 2024 14:30
@kira-syslogng
Copy link
Contributor

Build FAILURE

@bazsi bazsi force-pushed the implement-rfc6587-auto-detection branch 2 times, most recently from bc6fc6d to e551064 Compare February 4, 2024 18:35
@kira-syslogng
Copy link
Contributor

Build FAILURE

2 similar comments
@kira-syslogng
Copy link
Contributor

Build FAILURE

@kira-syslogng
Copy link
Contributor

Build FAILURE

@bazsi bazsi force-pushed the implement-rfc6587-auto-detection branch from 6ab5b22 to 9956ec4 Compare February 8, 2024 23:34
@kira-syslogng
Copy link
Contributor

Build FAILURE

@bazsi bazsi force-pushed the implement-rfc6587-auto-detection branch from 9956ec4 to 45b767c Compare February 22, 2024 14:32
@kira-syslogng
Copy link
Contributor

Build FAILURE

@bazsi bazsi force-pushed the implement-rfc6587-auto-detection branch from 45b767c to 5bd376e Compare March 17, 2024 06:06
@kira-syslogng
Copy link
Contributor

Build FAILURE

@bazsi bazsi force-pushed the implement-rfc6587-auto-detection branch from 5bd376e to d8b5258 Compare April 21, 2024 19:21
@kira-syslogng
Copy link
Contributor

Build FAILURE

@bazsi bazsi force-pushed the implement-rfc6587-auto-detection branch from d8b5258 to 887e55e Compare April 25, 2024 16:19
@bazsi bazsi changed the title RFC: Implement rfc6587 auto detection Implement rfc6587 auto detection Apr 25, 2024
@kira-syslogng
Copy link
Contributor

Build FAILURE

1 similar comment
@kira-syslogng
Copy link
Contributor

Build FAILURE

@bazsi bazsi force-pushed the implement-rfc6587-auto-detection branch from 585a39a to 6fe3f55 Compare April 25, 2024 19:12
@kira-syslogng
Copy link
Contributor

Build FAILURE

bazsi added 6 commits May 4, 2024 20:03
@bazsi
libtest: fixed LogTransportMock to not return bytes if the buffer siz…
d3045c4 
…e is 0

Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
@bazsi
logtransport: add read_ahead() method
f6e2d8d 
Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
@bazsi
logproto: add LogProtoAutoServer implementation
0267fa2 
Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
@bazsi
syslog: use rfc6587 style auto-detection when "framed" protocol is se…
8842f18 
…lected

Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
@bazsi
tests/copyright: updated policy about new files
0d4c429 
Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
@bazsi
news: updated news entry
98435b3 
Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
@bazsi bazsi force-pushed the implement-rfc6587-auto-detection branch from 6fe3f55 to 98435b3 Compare May 4, 2024 18:05
@bazsi bazsi mentioned this pull request May 4, 2024
Open
@kira-syslogng
Copy link
Contributor

Build FAILURE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrAnno MrAnno MrAnno left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bazsi @kira-syslogng @MrAnno