Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adult notebook #120

Open
wants to merge 24 commits into
base: main
Choose a base branch
from
Open

Adult notebook #120

wants to merge 24 commits into from

Conversation

Hilly12
Copy link
Contributor

@Hilly12 Hilly12 commented Aug 27, 2021

Add adult notebook tutorial

Copy link
Member

@simonhkswan simonhkswan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should avoid uploading the datasets to the repo. Can we upload them to synthesized-io/datasets?

src/_version.py Outdated Show resolved Hide resolved
@bogdansurdu
Copy link
Contributor

I think we should avoid uploading the datasets to the repo. Can we upload them to synthesized-io/datasets?

I think it might be a good idea to have datasets separate from the code, but isn't that repository private right now?

@bogdansurdu bogdansurdu marked this pull request as ready for review September 8, 2021 15:47
@simonhkswan simonhkswan added the type:documentation Improvements or additions to documentation label Sep 15, 2021
@codecov
Copy link

codecov bot commented Sep 17, 2021

Codecov Report

Merging #120 (153b7fc) into main (66d34f1) will decrease coverage by 1.86%.
The diff coverage is n/a.

❗ Current head 153b7fc differs from pull request most recent head 338d281. Consider uploading reports for the commit 338d281 to get more accurate results

@@            Coverage Diff             @@
##             main     #120      +/-   ##
==========================================
- Coverage   76.03%   74.16%   -1.87%     
==========================================
  Files          16       15       -1     
  Lines        1014      871     -143     
  Branches      234      186      -48     
==========================================
- Hits          771      646     -125     
+ Misses        194      181      -13     
+ Partials       49       44       -5     
Flag Coverage Δ
unittests 74.16% <ø> (-1.87%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/fairlens/scorer.py 70.58% <0.00%> (-2.31%) ⬇️
src/fairlens/metrics/significance.py 72.46% <0.00%> (-2.21%) ⬇️
src/fairlens/utils.py 76.35% <0.00%> (-2.03%) ⬇️
src/fairlens/metrics/statistics.py
src/fairlens/plot/distr.py 87.77% <0.00%> (+0.47%) ⬆️
src/fairlens/metrics/distance.py 82.89% <0.00%> (+2.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66d34f1...338d281. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Sep 17, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

1 similar comment
@sonarcloud
Copy link

sonarcloud bot commented Sep 17, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@simonhkswan simonhkswan removed their request for review April 4, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants