Updates for bower-specific folder changes and windows builds (covers things in issue 240) #245
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These updates should cover problems brought up in issue 240
I made some updates to build.coffee to point to bower-specific changes (components -> bower_components).
Also made changes to get the build to run under Windows:
\r
to thevariable.about.replace
regex to handle windows-specific line endings. That character wasn't getting picked up and it would cause the validation step to hang on windows builds.dir
accordingly. I placed the variableisWin
in the same location as the other variables to follow that file style and then used it in mkdir to initialize thedir
variable. It covers the case apollolux brought up on issue 240.I also changed the javascript references in tests to point to the new locations so that they would run. I wasn't sure if you were going to phase out qunit testing (and some of those files) -- that's what it looked like from previous changes -- but xregexp (for now, though I believe that changes in 3+) has a reference to qunit so I used it to make those work for the time being.
Last, I added a README.md in the build folder with updated build instructions.
Build now seems to be working for me on Bodhi 2.3 with node 0.8.25 (using node-sass 0.3.0) and node 0.10.12 (node-sass 0.5.0) as well as on Windows7 under node 0.10.
Notes:
node-sass
to thedevDependencies
but then found that the build wouldn't work under node 0.8. If I addednode-sass 0.3.x
instead, the build wouldn't work under node 0.10. So I left it out and just added that information to the build folder's README.md because I wasn't sure if you wanted to maintain support for node 0.8.TypeError: Object #<Object> has no method 'tmpDir'
because theos
module doesn't includetmpDir
until 0.7.11mkdir
functionality in build.coffee. I didn't really want to start adding dependencies and making those changes without some discussion.