feat: confirmation dialog for duplicate palette color addition #3334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Palette::is_color_present` is implemented to check duplicate color and trigger `Dock_PalEdit::confirm_duplicate_color_addition()` for user confirmation
KartikWatts
commented
Feb 20, 2024
| { | ||
| iterator iter; | ||
|
|
||
| for(iter=begin();iter!=end();++iter) |
There was a problem hiding this comment.
The current approach requires traversing through the vector for every color addition.
Seems fine to me though, but we may maintain a hashmap if we need further optimization. Thoughts are welcome.
Comment on lines
+551
to
+553
| Dock_PalEdit::confirm_duplicate_color_addition() | ||
| { | ||
| return App::get_ui_interface()->confirmation( |
There was a problem hiding this comment.
I have created a separate method to be called within add_color. Also, does this behavior require to be controlled with User preferences or a checkbox something like: Don't ask again.
However, I felt it should be okay, as this won't happen regularly anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the enhancement discussed in #3215
A confirmation dialog will be displayed to the User when they attempt to add a duplicate color again into the color palette.
A new public method
Palette::is_color_presentis implemented to check the duplicate color presenceAdditional private method
Dock_PalEdit::confirm_duplicate_color_addition()is implemented to be called within existingDock_PalEdit::add_colormethod for modularity to triggerUIInterface::confirmationcloses #3215