refactor: port layer to Cobra renderer: Noise gradient

[rodolforg]

No description provided.

[rodolforg]

Does supersample parameter any effect in original implementation? v1.0.2 or 1.4.x or 1.5.1 ...
Here it has none...

[ice0]

Does supersample parameter any effect in original implementation? v1.0.2 or 1.4.x or 1.5.1 ...
Here it has none...

That's strange. It did some calculations, but I didn't see any difference in the image.

if(super_sample&&pixel_size)
{
...
}

[rodolforg]

Neither did I...

[Svarov-RZM]

Does supersample parameter any effect in original implementation?

It does in all the versions. You just need to create a gradient where such effect would be visible, like in this case:

On the right side the gradient was generated with "Super Sampling" enabled and you can clearly see it's anti-aliased.

Do I personally think this parameter is needed? No. We already have a dedicated layer for this purpose called "Super Sample" which provides the user with more options for anti-aliasing.

[rodolforg]

And does the PR implementation work equally?

[Svarov-RZM]

And does the PR implementation work equally?

No, toggling the parameter has no effect.
Here's a test file:
NG-SuperSample.zip

[rodolforg]

I believe now I reproduce the supersample effect. :) @Svarov-RZM @ice0

[Svarov-RZM]

I believe now I reproduce the supersample effect. :)

Yeah, I confirm. It's working properly now.
Thank you for continuing on porting layers to the new engine, really appreciate it.
If you need any testing, just ping me.

[rodolforg]

@Svarov-RZM well, I try to port as long as I understand the engine and its code. :)
I don't check if it performed better, though.

[Svarov-RZM]

I don't check if it performed better, though.

Don't worry, it will perform better, since algorithm stays the same but the unnecessary wrapper is removed. Even if, by some convoluted reason, it won't, the performance can be addressed later after porting.

What's more important is stability. Currently layers such as Twirl, Curve Warp and Spherize are close to being unusable. They crash on zoom in (so annoying!) and often hang Synfig if you use it on complex work. But anyway, there's no hurry, when something is ready we'll test it and fix whatever issues come along.