feat: add "Add Layer" button to Toolbox

[neesaaa]

This commit addresses the issue #1139, where users were not noticing the "Add Layer" button in the "Layers Panel." The "Add Layer" button has been added to the Toolbox for better visibility.

Fix #1139

[mohamedAdhamc]

Updated the title to match style/conventional commits style. @neesaaa, you can check https://www.conventionalcommits.org/en/v1.0.0/ to learn more about it.

[ice0]

Hi, guys!

Looks good, the only problem I found is that if I close all windows this button is still active.
It might be worth disabling it like all other buttons.

[neesaaa]

can u please help me where to lookup as the code is enormous

[morevnaproject]

I like this improvement

[rodolforg]

can u please help me where to lookup as the code is enormous

Probably the best place is in Dock_Toolbox::refresh().
Take a look at the end of Dock_Toolbox::update_tools to see how it is done for the tools.

[neesaaa]

done hope it works well now

[yoSachinkr]

Honestly, I don't think this feature makes sense. If a person is using Synfig studio, then we can safely assume the person knows GIMP as well. And if the person is familiar with GIMP layers system, then he can automatically understand how Synfig layers system works.
There are already too many ways to add layers in Synfig. From the context menu, from the menu bar, from the context menu at layers panel, from the toolbar of layers panel.
I don't see the need of adding one more button just to add layers.

[neesaaa]

hi @yoSachinkr ,there are 4 ways to force quit any program however that does not make the quit button doesn't make sense

----------------------------------
1st- way Press Alt + F4
2nd-1. Press Control + Alt + Delete. 2. Choose Task Manager.3. Select the application that you want to force quit.4. Click End task.
3rd-1. Press Windows key + R.2. Type cmd into the search box and press Enter.3. Type tasklist into the Command Prompt. You'll then see a list of tasks and programs running on your computer.
4th- Enter taskkill/im [name_of_program].exe. For example, if you want to quit Firefox, you'd enter taskkill/im firefox.exe.Press Enter.
check :https://www.businessinsider.com/guides/tech/how-to-force-quit-on-windows

[yoSachinkr]

hi @yoSachinkr ,there are 4 ways to force quit any program however that does not make the quit button doesn't make sense

---------------------------------- 1st- way Press Alt + F4 2nd-1. Press Control + Alt + Delete. 2. Choose Task Manager.3. Select the application that you want to force quit.4. Click End task. 3rd-1. Press Windows key + R.2. Type cmd into the search box and press Enter.3. Type tasklist into the Command Prompt. You'll then see a list of tasks and programs running on your computer. 4th- Enter taskkill/im [name_of_program].exe. For example, if you want to quit Firefox, you'd enter taskkill/im firefox.exe.Press Enter. check :https://www.businessinsider.com/guides/tech/how-to-force-quit-on-windows

Hi @neesaaa , I was actually talking about this current feature request you've worked on.
All I meant was this "add layer" button in the toolbox is unnecessary.

[mohamedAdhamc]

Hi @neesaaa , I was actually talking about this current feature request you've worked on. All I meant was this "add layer" button in the toolbox is unnecessary.

Hello @yoSachinkr, I believe what he meant was that although there could be many ways of doing the same thing, it doesn't necessarily mean that they're all redundant and one is enough.

[yoSachinkr]

there are 4 ways to force quit any program however that does not make the quit button doesn't make sense

Hi @neesaaa @mohamedAdhamc ! I get that having different options to do the same thing can be useful, but I've never seen a program that shows the same gui element in two places at once, like having two buttons to quit in the same window. That would just make the interface look messy.
Also, we all know that the add layer button is not really a tool like the others. Putting it in the toolbox would make Synfig look like a jumbled mess.
If we really need another add layer button, it should go in the toolbar of the canvas panel.

[neesaaa]

there are 4 ways to force quit any program however that does not make the quit button doesn't make sense

Hi @neesaaa @mohamedAdhamc ! I get that having different options to do the same thing can be useful, but I've never seen a program that shows the same gui element in two places at once, like having two buttons to quit in the same window. That would just make the interface look messy. Also, we all know that the add layer button is not really a tool like the others. Putting it in the toolbox would make Synfig look like a jumbled mess. If we really need another add layer button, it should go in the toolbar of the canvas panel.

hi @yoSachinkr you clarified your point in two comments in the same window , which proves my point

[yoSachinkr]

Hi @neesaaa All I'm saying is putting two gui elements in a window that do exactly the same thing is a bad gui design.

[neesaaa]

@ice0 @rodolforg i think the build failed with no reason of mine

[ice0]

@ice0 @rodolforg i think the build failed with no reason of mine

Hi! Yes, there is a strange issue with build sometimes. I have rerun the failed jobs.

[rodolforg]

Does it need to be a RadioToolButton instead of a regular one?

[neesaaa]

• sorry was having exams
• i made it like the already exist button in layer panel
• because too , to make all things unified as all toolbox buttons and their radio button group
• but if u have different opinion point to me where to search as from my search it can be many things