refactor: add .sif icons to Classic theme for commands which used old Adwaita generic ones and more #3196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… which used old Adwaita generic ones
… Adwaita generic ones
…ar, process-stop and view-refresh commands which used old Adwaita generic ones
…ld Adwaita generic ones
Draft
|
With the intention of assisting with the review of this PR, I would like to add some screenshots showing the actual icons and the suggested ones. Take in count that some "actual" ones have 2 versions as each OS might have installed different versions of Adwaita icons so the actual look might change... Actually, this PR helps unifying the icon theme into a homogeneous one.
Cheers |
rodolforg
approved these changes
Sep 10, 2023
|
Hi, guys! I need a time before I merge this PR. |
|
@ice0 git LFS or just a git submodule? |
|
git submodule looks like a great option! |
|
@ice0 so we should move all .sif files into a git submodule? |
rodolforg
added a commit
to rodolforg/synfig
that referenced
this pull request
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the "refactor" part of #3167 as we decided to split it into "feat" and "refactor".
I also included here a few fixes to current theme as I think they fit better here and help for a smoother "feat" PR.
I won't create the "feat" PR till this one is approved and merged as it will modify same common files and could complicate things...
Cheers