fix: memory leak that caused a crash in parameters panel #3182
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2310 , Fixes #3180
The problem: A memory leak that was causing the crash as described more in #3180
The solution: Delete the widget after the edit is done. What was previously being done was only deleting one of the multiple instances that could be created when editing a parameter.
A problem encountered:
I get this warning
And this is the backtrace
It looks like it could be coming from the signal/handler not being disconnected properly after the widget is destroyed (assumption). But I'm kind of stuck trying to know it. @rodolforg @ice0 any ideas on what the problem might be ?