Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added lock guides feature and button #3179

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

Afterdie
Copy link
Contributor

closes #3158
I couldnt find any lock icons in iconcontroller.cpp for the button other than the lock keyframes icons.

@pgilfernandez
Copy link
Contributor

May I design an specific icon for this feature?

@pgilfernandez
Copy link
Contributor

For example this one could work:
lock_guideline_icon

If you like it, let me know and I create a PR with the .sif icon
=)

@Afterdie
Copy link
Contributor Author

Afterdie commented Sep 1, 2023

For example this one could work: lock_guideline_icon

If you like it, let me know and I create a PR with the .sif icon =)

Looks good 👍

@pgilfernandez
Copy link
Contributor

Perfect,
Once the PR gets merged I will create mine as we need to include the new icon and modify canvasview.cpp pointing to the new icon.

synfig-studio/src/gui/workarea.cpp Outdated Show resolved Hide resolved
synfig-studio/src/gui/workarea.cpp Outdated Show resolved Hide resolved
Copy link
Contributor

@rodolforg rodolforg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Afterdie, This PR misses its own icon

Copy link
Contributor

@rodolforg rodolforg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. @pgilfernandez will create it later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Lock guides feature and button
3 participants