-
-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding colors to color palette #3215
Comments
@morevnaproject do you agree? |
@rodolforg Since the change, when you pick a color with the eyedropper tool, the outline color never changes now, it's the fill color that changes. That means "adding outline color to the palette" will only add the same color to the palette again and again, which obviously is not intended. |
Hello, Duke this side. I find this issue interesting and want to resolve it. Can you assign this issue to me? |
Hi, Duke! Sure, assigned it to you. Currently Linux/macOS is recommended for development (you can easily run Linux in VM under Windows). P.S. Also, if you find any inaccuracies in the documentation or installation process, you can contribute to the documentation too :) |
Can you tell me in which file contains the color palette code. |
GUI: synfig-studio/src/gui/modules/mod_palette/ |
@rodolforg @ice0 Hi, as I felt this issue being inactive, I have tried to fix this locally already, if it is kindly possible, can it be please assigned to me, will raise a PR to fix this. Being one of the software I regularly use myself, it would be a great opportunity to be able to contribute. Attaching local patch functionality: Regards. Also, while testing this I came across a minor issue (in my opinion), a user can select the same color multiple times in the palette, if this needs to be fixed, please let me know, I may raise a separate issue and PR for this fix in that case, or as instructed. Would love to resolve this as well. Looking forward, thanks a lot. |
You can warn user that a equal color is already in palette and ask for confirmation if he/she really want to duplicate it. I don't know if you need to create a new issue; I guess you can directly create another PR if you want. |
@rodolforg Raised the PR for the issue mentioned.
Yeah, that would be great. I'll work on this and raise another PR for the functionality. Regards. |
@rodolforg Got delayed in implementing the enhancement. I have just implemented it and I'm raising the PR. Attaching GIF for reference: |
Describe the bug
With the current changes in eyedropper tool, it now sets the fill color to the picked color. But when you try to add color to the color palette, it adds the outline color into the palette, which causes inconvenience.
Expected behavior
Color palette should add fill color instead of outline color.
Screenshots
System information:
The text was updated successfully, but these errors were encountered: