gui: Fix Firefox bookmark favicon (fixes #9506) #9507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wonder if you can't just do without adding anything to the controller. This seems to work for me both in Firefox and Chromium. |
Thanks for the suggestion. Seems to work well and it's even simpler. I've updated the PR. |
Firefox uses the last specified favicon link for bookmarks, but only if it is available on initial page load. Remove the second link and use ng-href to change the icon instead.
|
Neat |
calmh
approved these changes
May 1, 2024
calmh
added a commit
to calmh/syncthing
that referenced
this pull request
May 9, 2024
* main: (45 commits) build: Use Go 1.22.3 at minimum build: Use Go 1.22.3 at minimum gui: Add Hindi (hi) translation template (syncthing#9530) gui, man, authors: Update docs, translations, and contributors lib/connections: Add syncthing_connections_active metric (fixes syncthing#9527) (syncthing#9528) etc: Use 7MiB buffer size (syncthing#9524) gui: Fix Firefox bookmark favicon (fixes syncthing#9506) (syncthing#9507) gui, man, authors: Update docs, translations, and contributors gui, man, authors: Update docs, translations, and contributors gui, man, authors: Update docs, translations, and contributors lib/nat: Don't crash on empty address list (fixes syncthing#9503) (syncthing#9504) lib/db: Drop indexes for outgoing data to force refresh (ref syncthing#9496) (syncthing#9502) gui: Fix missing link to device editor for names with superscript (ref syncthing#9472) (syncthing#9494) lib/db: Hold update lock while taking snapshot (syncthing#9496) build: Update dependencies (syncthing#9497) gui, man, authors: Update docs, translations, and contributors gui, man, authors: Update docs, translations, and contributors Removed no longer relevant Bountysource link (syncthing#9480) lib/api: Missing return after HTTP error lib/api: Extract session store (syncthing#9425) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Firefox uses the last specified favicon link for bookmarks, but only if it is available on initial page load.
Remove the second link and use ng-href to change the icon instead.
I'm not really familiar with AngularJS, feel free to offer suggestions for improvements.
Testing
Briefly tested on Firefox 124.0.2 and Chrome 123.0.6312.105.