gui: Add explanation to options enabled or disabled per folder type #9367
Conversation
There was a problem hiding this comment.
I'm not quite sure whether centralizing in this way is really helpful. When we generate translations, the strings are already deduplicated. And some cases here might benefit from not using $translate.instant() for better performance. I remember reading somewhere that in contrast to translating HTML nodes, that function runs synchronously and therefore creates more lag on the page. Could you check that again please?
| @@ -282,6 +285,9 @@ | |||
| <p translate class="help-block"> | |||
There was a problem hiding this comment.
Just an idea, we could hide this regular help block when the "always enabled" message appears. I think it's better to have less text overall. If the option cannot be changed, the explanation what it would do is not needed either. If someone comes specifically to enable that option, they probably know why they want it and therefore have gotten their explanation somewhere else already. I.e. the only important bit for them is that something prevents them from doing what they wanted.
There was a problem hiding this comment.
Tried doing that but I don't think it's really a good idea. This is because with no explanation present, the user will be forced to add a new folder of another type just to be able to know what the option does.
Currently, some options are automatically enabled or disabled depending on the folder type. However, there is no explanation in the GUI on why the options are like that. Thus, add short explanatory notes to each case, where the option is either disabled or enabled according to the current folder type. Signed-off-by: Tomasz Wilczyński <twilczynski@naver.com>
tomasz1986
force-pushed
the
tomasz86/prs/gui/explain-why-File-Pull-Order-is-disabled-for-Send-Only-folders
branch
from
3299f4f
to
73d2531
Compare
Signed-off-by: Tomasz Wilczyński <twilczynski@naver.com>
|
I had another look at this and took it for a test-drive. I must say the looks are not really appealing. It would be better to hide this information in a tooltip that displays when hovering over the input elements (just like the "forbidden" mouse cursor). I'm not quite sure how we currently support conditional tooltips though. Found these two links that suggest it is possible, but maybe not with our default tooltip implementation? https://stackoverflow.com/questions/21177176/conditional-tooltip-with-bootstrap-3-and-angular |
gui: Add explanation to options enabled or disabled per folder type
Currently, some options are automatically enabled or disabled depending
on the folder type. However, there is no explanation in the GUI on why
the options are like that. Thus, add short explanatory notes to each
case, where the option is either disabled or enabled according to the
current folder type.
Signed-off-by: Tomasz Wilczyński twilczynski@naver.com
Screenshots