Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build.go: validate -version argument against regex from lib/build #9322

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

build.go: validate -version argument against regex from lib/build #9322

wants to merge 3 commits into from

Commits on Feb 9, 2024

  1. build.go: validate -version argument against regex from lib/build 

    In syncthing#9267 it was mentioned that binaries built with incompatible
versions can't be run. To avoid situations like this completely,
same regex is used to validate manually provided verions.
    @gudvinr
    gudvinr committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    c6d865b View commit details
    Browse the repository at this point in the history

  2. build.go: check version from getVersion as well

    @gudvinr
    gudvinr committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    4b268d4 View commit details
    Browse the repository at this point in the history

  3. wip

    @calmh @gudvinr
    calmh authored and gudvinr committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    e2c5f1d View commit details
    Browse the repository at this point in the history