lib/fs: Handle DST changes on FAT on Android (fixes #9227) #9231
Conversation
|
@calmh I cannot determine if this is ready to work "as is" . Do you think there's a chance as I expect you did not test it on Android because that's not your main OS to work on. If you're fine with it, I could throw it into a Syncthing-Fork prerelease and grab feedback from users if it works. What is the best way to simulate DST changes? Is it sufficient if the user disables "automatically retrieve time from provider" and disables NTP by going into airplane mode? The fork has a "recent changes" UI , showing what has scanned (so was detected as changed). I would need a user with enough knowledge to test this fairly and not just run the app and "oh it is syncing". Maybe it can also be verified in emulator? Could I please have a log line indicating if the "time is off by one hour exactly" fired or not? |
* main: lib/fs: Reduce memory usage in xattrs handling (syncthing#9251) lib/model: Improve LastSeen handling (syncthing#9256) lib/scanner: Record inode change time for directories and symlinks (syncthing#9250) lib/api: Improve ignore loading error handling (fixes syncthing#9253) (syncthing#9254) gui, man, authors: Update docs, translations, and contributors lib/fs: Better equality comparison in mtimefs cmd/stcrashreceiver: Add metrics for diskstore inventory cmd/stcrashreceiver: Minor cleanup, stricter file permissions cmd/stcrashreceiver: Add metrics for incoming reports cmd/ursrv: Add metrics for incoming reports gui, man, authors: Update docs, translations, and contributors gui: Specialize a special-purpose checkbox style (syncthing#9236) gui, man, authors: Update docs, translations, and contributors build: Support new nested namespaces in Weblate downloads lib/model: Acquire fmut lock in ensureIndexHandler (fixes syncthing#9234) (syncthing#9235) gui: Allow to translate "unknown device" (syncthing#9229)
|
Indeed I have not even compiled for Android, only simulated what I hope are similar conditions. I added a log line, needs |
|
@calmh Perfect, thank you. |
|
Editing... I'm just giving this a shot on the android emulator... STARTING STICK: v1.27.1.0 (without this PR)
Initial scan done. Now let's change the DST from GMT+0 to GMT+1...
I didn't get any recent changes by hitting RESCAN in Syncthing.
I expected to reproduce the original problem that all files on the shared SD folger were rescanned... :o Even setting from GMT-1 to GMT+6 doesn't trigger the rescan listing files as "recent changes" on Syncthing's Web UI. I'm at a loss how to reproduce the original problem. |
Most likely, yes (or perhaps devices with separate SD-cards? If that still exists). My guess is that it mostly (or only) affects devices running Android < 11 ór a kernel version below 5.4; as that's when the old FS was deprecated (SDCardFS). Android Emulators running a recent version (Just tested a Pixel 7 - API 33) use EXT4 combined with a FUSE-implementation, the same is noticeable on my Galaxy S21 FE (although there F2FS is also used). As this seems to be a FAT-specific issue, it most likely isn't relevant anymore for devices running Android >= 11 ánd kernel >= 5.4. |
|
I think you should be able to reproduce this easily on a real device with an external SD card inserted. Those are always formatted as FAT, also in the newest versions of Android (unless you mount them as "internal storage"). In the original issue (https://forum.syncthing.net/t/unwanted-full-rescan-resync-sd-card-syncthing-android-after-timezone-daylight-saving-change/21064), the problem happened specifically with files located on an SD card. |
|
@tomasz1986 the problem here is, I do not own a device with sdcard slot :-(. Maybe my emulator was Fuse based. |
Here, you guys can argue about this. I'll go diving in the meantime.