-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WebAuthn support to GUI #9175
Draft
emlun
wants to merge
93
commits into
syncthing:main
Choose a base branch
from
emlun:webauthn
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Commits on Oct 15, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 1b5dd84 - Browse repository at this point
Copy the full SHA 1b5dd84View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8a51efe - Browse repository at this point
Copy the full SHA 8a51efeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7f17953 - Browse repository at this point
Copy the full SHA 7f17953View commit details -
Configuration menu - View commit details
-
Copy full SHA for 40274e7 - Browse repository at this point
Copy the full SHA 40274e7View commit details -
Configuration menu - View commit details
-
Copy full SHA for d965882 - Browse repository at this point
Copy the full SHA d965882View commit details -
Configuration menu - View commit details
-
Copy full SHA for eb2d616 - Browse repository at this point
Copy the full SHA eb2d616View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6c66916 - Browse repository at this point
Copy the full SHA 6c66916View commit details -
Configuration menu - View commit details
-
Copy full SHA for 47ba3fd - Browse repository at this point
Copy the full SHA 47ba3fdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 86fd758 - Browse repository at this point
Copy the full SHA 86fd758View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1ac6ce9 - Browse repository at this point
Copy the full SHA 1ac6ce9View commit details -
Configuration menu - View commit details
-
Copy full SHA for a0b8407 - Browse repository at this point
Copy the full SHA a0b8407View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5eeae91 - Browse repository at this point
Copy the full SHA 5eeae91View commit details -
Configuration menu - View commit details
-
Copy full SHA for 39699c3 - Browse repository at this point
Copy the full SHA 39699c3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 648554e - Browse repository at this point
Copy the full SHA 648554eView commit details -
Configuration menu - View commit details
-
Copy full SHA for de3f323 - Browse repository at this point
Copy the full SHA de3f323View commit details -
Configuration menu - View commit details
-
Copy full SHA for c6757e7 - Browse repository at this point
Copy the full SHA c6757e7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9e7a8d3 - Browse repository at this point
Copy the full SHA 9e7a8d3View commit details -
Configuration menu - View commit details
-
Copy full SHA for abbeaa2 - Browse repository at this point
Copy the full SHA abbeaa2View commit details -
Configuration menu - View commit details
-
Copy full SHA for f4a0d6f - Browse repository at this point
Copy the full SHA f4a0d6fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 530cb4a - Browse repository at this point
Copy the full SHA 530cb4aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 42fc63b - Browse repository at this point
Copy the full SHA 42fc63bView commit details -
Configuration menu - View commit details
-
Copy full SHA for a643041 - Browse repository at this point
Copy the full SHA a643041View commit details -
Configuration menu - View commit details
-
Copy full SHA for cbf2fd1 - Browse repository at this point
Copy the full SHA cbf2fd1View commit details
Commits on Oct 24, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 1c131a3 - Browse repository at this point
Copy the full SHA 1c131a3View commit details -
2
Configuration menu - View commit details
-
Copy full SHA for 1c5e4ba - Browse repository at this point
Copy the full SHA 1c5e4baView commit details
Commits on Nov 5, 2023
-
Remove isNamespacedTranslationId heuristic
Instead, apply the namespace separation only if the ID is set explicitly rather than inferred to equal the value.
Configuration menu - View commit details
-
Copy full SHA for 384a514 - Browse repository at this point
Copy the full SHA 384a514View commit details -
Configuration menu - View commit details
-
Copy full SHA for 832849d - Browse repository at this point
Copy the full SHA 832849dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 909fdb9 - Browse repository at this point
Copy the full SHA 909fdb9View commit details -
Omit WebAuthn Credentials from advanced settings
Since this is an object structure, rather than a comma-separated list of strings, it's shown in the Advanced Settings as "[Object object]". Of course, any attempt to edit this value makes the config fail to parse when saved.
Configuration menu - View commit details
-
Copy full SHA for 782ba88 - Browse repository at this point
Copy the full SHA 782ba88View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3d04e78 - Browse repository at this point
Copy the full SHA 3d04e78View commit details -
Configuration menu - View commit details
-
Copy full SHA for 99690e7 - Browse repository at this point
Copy the full SHA 99690e7View commit details
Commits on Nov 19, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 22b5b2e - Browse repository at this point
Copy the full SHA 22b5b2eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2dc0046 - Browse repository at this point
Copy the full SHA 2dc0046View commit details -
Configuration menu - View commit details
-
Copy full SHA for bfda3e3 - Browse repository at this point
Copy the full SHA bfda3e3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 400ef34 - Browse repository at this point
Copy the full SHA 400ef34View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8c3564a - Browse repository at this point
Copy the full SHA 8c3564aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2d16cfa - Browse repository at this point
Copy the full SHA 2d16cfaView commit details
Commits on Nov 22, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 6cd22b5 - Browse repository at this point
Copy the full SHA 6cd22b5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9135b7d - Browse repository at this point
Copy the full SHA 9135b7dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4da0eba - Browse repository at this point
Copy the full SHA 4da0ebaView commit details -
Configuration menu - View commit details
-
Copy full SHA for f3d8182 - Browse repository at this point
Copy the full SHA f3d8182View commit details -
Array.filter is already used elsewhere in the file.
Configuration menu - View commit details
-
Copy full SHA for 353d1cf - Browse repository at this point
Copy the full SHA 353d1cfView commit details
Commits on Feb 18, 2024
-
This will make it easier to merge main into the `webauthn` branch (PR syncthing#9175), as there are about to be several services and API handlers that read and set cookies and session state.
Configuration menu - View commit details
-
Copy full SHA for cb1ca3c - Browse repository at this point
Copy the full SHA cb1ca3cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4da8a10 - Browse repository at this point
Copy the full SHA 4da8a10View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6c8e0af - Browse repository at this point
Copy the full SHA 6c8e0afView commit details -
Configuration menu - View commit details
-
Copy full SHA for a61d08a - Browse repository at this point
Copy the full SHA a61d08aView commit details -
Configuration menu - View commit details
-
Copy full SHA for fab687c - Browse repository at this point
Copy the full SHA fab687cView commit details -
Configuration menu - View commit details
-
Copy full SHA for c63b9a8 - Browse repository at this point
Copy the full SHA c63b9a8View commit details -
Configuration menu - View commit details
-
Copy full SHA for e9c95a1 - Browse repository at this point
Copy the full SHA e9c95a1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 85e4b3c - Browse repository at this point
Copy the full SHA 85e4b3cView commit details
Commits on Mar 10, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 0871890 - Browse repository at this point
Copy the full SHA 0871890View commit details -
Configuration menu - View commit details
-
Copy full SHA for 442f78f - Browse repository at this point
Copy the full SHA 442f78fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 65f2612 - Browse repository at this point
Copy the full SHA 65f2612View commit details -
Configuration menu - View commit details
-
Copy full SHA for 785b876 - Browse repository at this point
Copy the full SHA 785b876View commit details -
Configuration menu - View commit details
-
Copy full SHA for b2b9428 - Browse repository at this point
Copy the full SHA b2b9428View commit details -
Configuration menu - View commit details
-
Copy full SHA for db6a0f6 - Browse repository at this point
Copy the full SHA db6a0f6View commit details
Commits on Mar 31, 2024
-
Configuration menu - View commit details
-
Copy full SHA for b671a9a - Browse repository at this point
Copy the full SHA b671a9aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 01b8d76 - Browse repository at this point
Copy the full SHA 01b8d76View commit details
Commits on Apr 6, 2024
-
Configuration menu - View commit details
-
Copy full SHA for ae15072 - Browse repository at this point
Copy the full SHA ae15072View commit details -
Configuration menu - View commit details
-
Copy full SHA for 551918d - Browse repository at this point
Copy the full SHA 551918dView commit details -
Configuration menu - View commit details
-
Copy full SHA for ac8a48c - Browse repository at this point
Copy the full SHA ac8a48cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 774f1f9 - Browse repository at this point
Copy the full SHA 774f1f9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2fe6f04 - Browse repository at this point
Copy the full SHA 2fe6f04View commit details -
Configuration menu - View commit details
-
Copy full SHA for bcd8b7a - Browse repository at this point
Copy the full SHA bcd8b7aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2ae7bf2 - Browse repository at this point
Copy the full SHA 2ae7bf2View commit details -
Configuration menu - View commit details
-
Copy full SHA for b41da4e - Browse repository at this point
Copy the full SHA b41da4eView commit details -
Configuration menu - View commit details
-
Copy full SHA for e6505e7 - Browse repository at this point
Copy the full SHA e6505e7View commit details
Commits on Apr 7, 2024
-
Configuration menu - View commit details
-
Copy full SHA for fc778e8 - Browse repository at this point
Copy the full SHA fc778e8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3110830 - Browse repository at this point
Copy the full SHA 3110830View commit details -
- Value assigned to a variable is never read before being overwritten: https://app.deepsource.com/gh/syncthing/syncthing/run/20c38634-2a03-43a5-b47d-da9564205a82/go/SCC-SA4006?listindex=0 - Inappropriate usage of t.Parallel() method: https://app.deepsource.com/gh/syncthing/syncthing/run/20c38634-2a03-43a5-b47d-da9564205a82/go/GO-W6007?listindex=1 - Found time.Now().Sub(t) instead of time.Since(t) https://app.deepsource.com/gh/syncthing/syncthing/run/20c38634-2a03-43a5-b47d-da9564205a82/go/SCC-S1012?listindex=2 - Unsupported argument to functions in encoding/binary https://app.deepsource.com/gh/syncthing/syncthing/run/20c38634-2a03-43a5-b47d-da9564205a82/go/SCC-SA1003?listindex=3 - Unused code https://app.deepsource.com/gh/syncthing/syncthing/run/20c38634-2a03-43a5-b47d-da9564205a82/go/SCC-U1000?listindex=4 - Empty string test can be improved https://app.deepsource.com/gh/syncthing/syncthing/run/20c38634-2a03-43a5-b47d-da9564205a82/go/CRT-A0004?listindex=6 - Unused method receiver https://app.deepsource.com/gh/syncthing/syncthing/run/20c38634-2a03-43a5-b47d-da9564205a82/go/RVV-B0013?listindex=8 - Method modifies receiver https://app.deepsource.com/gh/syncthing/syncthing/run/20c38634-2a03-43a5-b47d-da9564205a82/go/RVV-B0006?listindex=9 - Type "WebauthnCredential" has both value and pointer receivers https://app.deepsource.com/gh/syncthing/syncthing/run/20c38634-2a03-43a5-b47d-da9564205a82/go/GO-W1029?listindex=10 - Unused parameter in function https://app.deepsource.com/gh/syncthing/syncthing/run/20c38634-2a03-43a5-b47d-da9564205a82/go/RVV-B0012?listindex=11 - Use %q to quote a string in fmt.Sprintf format specifiers https://app.deepsource.com/gh/syncthing/syncthing/run/20c38634-2a03-43a5-b47d-da9564205a82/go/GO-R4002?listindex=12
Configuration menu - View commit details
-
Copy full SHA for 9201aee - Browse repository at this point
Copy the full SHA 9201aeeView commit details -
Hopefully fixes DeepSource lint: `func TestWebauthnRegistration has a cyclomatic complexity of 38 with "very-high" risk` https://app.deepsource.com/gh/syncthing/syncthing/run/20c38634-2a03-43a5-b47d-da9564205a82/go/GO-R1005?listindex=13
Configuration menu - View commit details
-
Copy full SHA for 7775b04 - Browse repository at this point
Copy the full SHA 7775b04View commit details -
Configuration menu - View commit details
-
Copy full SHA for 57fea60 - Browse repository at this point
Copy the full SHA 57fea60View commit details -
Configuration menu - View commit details
-
Copy full SHA for 984ca37 - Browse repository at this point
Copy the full SHA 984ca37View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9ce6562 - Browse repository at this point
Copy the full SHA 9ce6562View commit details -
Configuration menu - View commit details
-
Copy full SHA for a6f0d41 - Browse repository at this point
Copy the full SHA a6f0d41View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1057fd6 - Browse repository at this point
Copy the full SHA 1057fd6View commit details -
- Inappropriate usage of t.Parallel() method https://app.deepsource.com/gh/syncthing/syncthing/run/da7c6acc-3750-4921-be99-e21f1113387e/go/GO-W6007?listindex=0 - append possibly assigns to a wrong variable https://app.deepsource.com/gh/syncthing/syncthing/run/da7c6acc-3750-4921-be99-e21f1113387e/go/CRT-D0001?listindex=4
Configuration menu - View commit details
-
Copy full SHA for 3251370 - Browse repository at this point
Copy the full SHA 3251370View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9c00ab7 - Browse repository at this point
Copy the full SHA 9c00ab7View commit details
Commits on Apr 14, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 1ef0656 - Browse repository at this point
Copy the full SHA 1ef0656View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8851819 - Browse repository at this point
Copy the full SHA 8851819View commit details -
Configuration menu - View commit details
-
Copy full SHA for 689f3c5 - Browse repository at this point
Copy the full SHA 689f3c5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 796e90a - Browse repository at this point
Copy the full SHA 796e90aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 462238a - Browse repository at this point
Copy the full SHA 462238aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0e2c0b2 - Browse repository at this point
Copy the full SHA 0e2c0b2View commit details -
Configuration menu - View commit details
-
Copy full SHA for b5c4142 - Browse repository at this point
Copy the full SHA b5c4142View commit details -
Configuration menu - View commit details
-
Copy full SHA for 78a72a1 - Browse repository at this point
Copy the full SHA 78a72a1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2c747b4 - Browse repository at this point
Copy the full SHA 2c747b4View commit details
Commits on May 12, 2024
-
Configuration menu - View commit details
-
Copy full SHA for ba8668e - Browse repository at this point
Copy the full SHA ba8668eView commit details -
Configuration menu - View commit details
-
Copy full SHA for e477ba3 - Browse repository at this point
Copy the full SHA e477ba3View commit details -
Configuration menu - View commit details
-
Copy full SHA for e841612 - Browse repository at this point
Copy the full SHA e841612View commit details -
Make shutdown timeout configurable for tests
TestWebauthnConfigChanges seems to need a longer shutdown timeout when running on GitHub Actions. The problem manifests in errors like this: ``` 2024-05-05T17:00:45.0503602Z api_test.go:2919: TestWebauthnConfigChanges/Can_edit_GUIConfiguration.WebauthnUserId Put "http://127.0.0.1:37585/rest/config/gui": EOF [] 2024-05-05T17:00:45.0566336Z --- FAIL: TestWebauthnConfigChanges/Can_edit_GUIConfiguration.WebauthnUserId (0.52s) ``` indicating that the server was forcefully shut down (or panicked, but that was ruled out in these cases) before the request was fully written.
Configuration menu - View commit details
-
Copy full SHA for 7ed2db8 - Browse repository at this point
Copy the full SHA 7ed2db8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 961720f - Browse repository at this point
Copy the full SHA 961720fView commit details -
Configuration menu - View commit details
-
Copy full SHA for b5d3767 - Browse repository at this point
Copy the full SHA b5d3767View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.