Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct various typos #8870

Merged
merged 3 commits into from May 9, 2023
Merged

Correct various typos #8870

merged 3 commits into from May 9, 2023

Conversation

goggle
Copy link
Contributor

@goggle goggle commented Apr 12, 2023

Purpose

Corrects some typos that I've found in the repository.

Signed-off-by: Alexander Seiler <seileralex@gmail.com>
@calmh
Copy link
Member

calmh commented Apr 12, 2023

Half of this is in autogenerated files. If you avoid those, the rest makes sense.

Signed-off-by: Alexander Seiler <seileralex@gmail.com>
Copy link
Member

@acolomb acolomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in code, but I haven't tested it or checked whether all instances of the variable renames were caught.

@@ -1994,7 +1994,7 @@ These endpoints require the \fBgui.debugging\fP configuration option to
be enabled and yield an access denied error code otherwise.
.SS GET /rest/debug/peerCompletion
.sp
Summarizes the completion precentage for each remote device. Returns an object
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is autogenerated from the docs repo

Copy link
Member

@calmh calmh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Remove changes to autogenerated files)

Signed-off-by: Alexander Seiler <seileralex@gmail.com>
@calmh calmh merged commit ddce692 into syncthing:main May 9, 2023
16 checks passed
calmh added a commit to calmh/syncthing that referenced this pull request May 9, 2023
* main: (42 commits)
  all: Correct various typos (syncthing#8870)
  gui, man, authors: Update docs, translations, and contributors
  lib/model: Set platform data, incl. copying ownership, for new folders w/ NoPermissions flag (syncthing#8883)
  gui: Add Thai (th) translation template. (syncthing#8887)
  build: Produce nightly release builds
  gui, man, authors: Update docs, translations, and contributors
  build: Bump actions version; fix Node 12 deprecation warning (syncthing#8881)
  build: Build Debian packages
  build: Sign for upgrades
  build: Notarize mac builds
  build(deps): bump github.com/quic-go/quic-go from 0.33.0 to 0.34.0 (syncthing#8877)
  gui, man, authors: Update docs, translations, and contributors
  lib/ignore: Properly handle non-existing included ignore-files (fixes syncthing#8764) (syncthing#8874)
  lib/connections: Avoid using nil lanChecker
  gui, man, authors: Update docs, translations, and contributors
  lib/config, lib/connections: Configurable protocol priority (ref syncthing#8626) (syncthing#8868)
  build: Upgrade recli (fixes syncthing#8503) (syncthing#8871)
  build: Update dependencies (syncthing#8869)
  lib/model: Improve path generation for auto accepted folders (fixes syncthing#8859) (syncthing#8860)
  docs: fix typo (syncthing#8857)
  ...
@calmh calmh added this to the v1.23.5 milestone May 9, 2023
calmh added a commit to calmh/syncthing that referenced this pull request Jun 4, 2023
* main:
  gui: Remove HTML support in tooltips
  cmd/syncthing: Use correct binary when restarting monitor (syncthing#8919)
  build(deps): bump github.com/minio/sha256-simd from 1.0.0 to 1.0.1 (syncthing#8916)
  build: Increase concurrency, add "basic checks" gatekeeper
  gui, man, authors: Update docs, translations, and contributors
  gui, man, authors: Update docs, translations, and contributors
  lib/model: Set platform data for new folders w/ ignorePerms (ref syncthing#8883) (syncthing#8907)
  gui, man, authors: Update docs, translations, and contributors
  lib: replace `Readdir(-1)` with `os.ReadDir` (syncthing#8901)
  lib/api: Allow BindDN to exclude any username formatting (fixes syncthing#8899) (syncthing#8900)
  build: Attempt cross compilation for ~all targets, allow it to fail
  lib/fs: Fix root path handling for Windows (fixes syncthing#8778)
  all: Grand test refactor (fixes syncthing#8779, fixes syncthing#8799)
  all: Correct various typos (syncthing#8870)
@st-review st-review added the frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion label May 8, 2024
@syncthing syncthing locked and limited conversation to collaborators May 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants