Prefer injecting preferences instead of using PreferenceManager directly #2073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamszewe
force-pushed
the
prefer-injecting-default-shared-preferences
branch
from
79449d5
to
a8d5f81
Compare
adamszewe
force-pushed
the
prefer-injecting-default-shared-preferences
branch
from
a8d5f81
to
e535149
Compare
adamszewe
force-pushed
the
prefer-injecting-default-shared-preferences
branch
from
e535149
to
fdd860a
Compare
imsodin
reviewed
Apr 4, 2024
| @@ -240,7 +240,7 @@ private boolean shouldSkipSlide(Slide slide) { | |||
| case API_LEVEL_30: | |||
| // Skip if running as root, as that circumvents any Android FS restrictions. | |||
| return upgradedToApiLevel30() | |||
| || PreferenceManager.getDefaultSharedPreferences(this).getBoolean(Constants.PREF_USE_ROOT, false); | |||
There was a problem hiding this comment.
Shouldn't there now be an unused import for PreferenceManager? Same on all other files.
imsodin
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prefer injecting preferences instead of using
PreferenceManager.getDefaultSharedPreferences(context)directly.Changes
PreferenceManager.getDefaultSharedPreferences(context)by injecting SharedPreferences instead