Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing typo Github to GitHub (fixes #2041) #2070

Merged
merged 2 commits into from Mar 22, 2024

Conversation

Jaspitta
Copy link
Contributor

Changed project wide the Github name to GitHub to fix the issue 2041

@acolomb acolomb linked an issue Mar 19, 2024 that may be closed by this pull request
@acolomb acolomb changed the title Fixing typo Github to GitHub describe in issue 2041 Fixing typo Github to GitHub (fixes #2041) Mar 19, 2024
@imsodin
Copy link
Member

imsodin commented Mar 22, 2024

@acolomb Can you please confirm that this mass change is fine for weblate (or not).

@acolomb
Copy link
Member

acolomb commented Mar 22, 2024

@acolomb Can you please confirm that this mass change is fine for weblate (or not).

I suppose it will work, Weblate should pick up changed translations. Make sure to have the changes from Weblate imported up-to-date though before pulling this off. Better to fix potential merge conflicts in the PR than afterwards on Weblate.

One downside I see is that @Catfriend1 will need to make the same adjustment in order to still get automatic translation propagation of common strings between the fork and upstream.

@imsodin imsodin merged commit 8cff736 into syncthing:main Mar 22, 2024
1 check passed
acolomb added a commit to acolomb/syncthing-android that referenced this pull request Mar 23, 2024
Apply essentially the same change as in upstream, to reduce diff:
syncthing#2070
Catfriend1 pushed a commit to Catfriend1/syncthing-android that referenced this pull request Mar 23, 2024
Apply essentially the same change as in upstream, to reduce diff:
syncthing/syncthing-android#2070
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typo error in welcome screen
3 participants