New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expr: fixed limit/series incorrect simplification, added regression test #26544
base: master
Are you sure you want to change the base?
Conversation
using ratsimp on s1 in series to provide correct simplified solution
✅ Hi, I am the SymPy bot. I'm here to help you write a release notes entry. Please read the guide on how to write release notes. Your release notes are in good order. Here is what the release notes will look like:
This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.13. Click here to see the pull request description that was parsed.
|
return collect(s1, x) + o | ||
from sympy.simplify.ratsimp import ratsimp | ||
return collect(ratsimp(s1), x) + o |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure about calling ratsimp
here. If we want to canonicalise the form of the output then it should be done systematically and that really means using ringseries I think.
using ratsimp on s1 in series to provide correct simplified solution
References to other Issues or PRs
Fixes #9173
Brief description of what is fixed or changed
Other comments
Release Notes