Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expr: fixed limit/series incorrect simplification, added regression test #26544

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Qaaee123
Copy link

using ratsimp on s1 in series to provide correct simplified solution

References to other Issues or PRs

Fixes #9173

Brief description of what is fixed or changed

Other comments

Release Notes

  • core
    • used ratsimp to proper display simplified series output. Before, would output incredibly complex series. Now, outputs correct simplified series.

using ratsimp on s1 in series to provide correct simplified solution
@sympy-bot
Copy link

Hi, I am the SymPy bot. I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

  • core
    • used ratsimp to proper display simplified series output. Before, would output incredibly complex series. Now, outputs correct simplified series. (#26544 by @Qaaee123)

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.13.

Click here to see the pull request description that was parsed.
using ratsimp on s1 in series to provide correct simplified solution

<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234" (see
https://tinyurl.com/auto-closing for more information). Also, please
write a comment on that issue linking back to this pull request once it is
open. -->
Fixes #9173

#### Brief description of what is fixed or changed


#### Other comments


#### Release Notes

<!-- Write the release notes for this release below between the BEGIN and END
statements. The basic format is a bulleted list with the name of the subpackage
and the release note for this PR. For example:

* solvers
  * Added a new solver for logarithmic equations.

* functions
  * Fixed a bug with log of integers. Formerly, `log(-x)` incorrectly gave `-log(x)`.

* physics.units
  * Corrected a semantical error in the conversion between volt and statvolt which
    reported the volt as being larger than the statvolt.

or if no release note(s) should be included use:

NO ENTRY

See https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more
information on how to write release notes. The bot will check your release
notes automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->

- core
  - used ratsimp to proper display simplified series output. Before, would output incredibly complex series. Now, outputs correct simplified series.

<!-- END RELEASE NOTES -->

Comment on lines -3071 to +3072
return collect(s1, x) + o
from sympy.simplify.ratsimp import ratsimp
return collect(ratsimp(s1), x) + o
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about calling ratsimp here. If we want to canonicalise the form of the output then it should be done systematically and that really means using ringseries I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Series/limit fails unless expression is simplified first.
3 participants