Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented add handler in BaseVectorField and Differential #26499

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

davidepittet
Copy link

@davidepittet davidepittet commented Apr 14, 2024

References to other Issues or PRs

Partially fixes #26478: this issue has multiple steps to be taken, this addresses the first one.

Brief description of what is fixed or changed

A __add__ method is implemented in both BaseVectorField and Differential classes, that checks type constraint before delegating sum over to Add class.

Other comments

I would like a feedback on the way I implemented this change. In particular, I am uncertain whether to follow this path with the subsequent steps or write a new class to handle tensor product sum, similarly to MatrixExpr and MatrixAdd.

Release Notes

  • diffgeom
    • Implemented __add__ method for BaseVectorField and Differential

@sympy-bot
Copy link

sympy-bot commented Apr 14, 2024

Hi, I am the SymPy bot. I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

  • diffgeom

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.13.

Click here to see the pull request description that was parsed.
<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234" (see
https://tinyurl.com/auto-closing for more information). Also, please
write a comment on that issue linking back to this pull request once it is
open. -->

Partially fixes #26478: this issue has multiple steps to be taken, this addresses the first one.

#### Brief description of what is fixed or changed
A \_\_add__ method is implemented in both BaseVectorField and Differential classes, that checks type constraint before delegating sum over to Add class.

#### Other comments
I would like a feedback on the way I implemented this change. In particular, I am uncertain whether to follow this path with the subsequent steps or write a new class to handle tensor product sum, similarly to MatrixExpr and MatrixAdd.

#### Release Notes

<!-- Write the release notes for this release below between the BEGIN and END
statements. The basic format is a bulleted list with the name of the subpackage
and the release note for this PR. For example:

* solvers
  * Added a new solver for logarithmic equations.

* functions
  * Fixed a bug with log of integers. Formerly, `log(-x)` incorrectly gave `-log(x)`.

* physics.units
  * Corrected a semantical error in the conversion between volt and statvolt which
    reported the volt as being larger than the statvolt.

or if no release note(s) should be included use:

NO ENTRY

See https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more
information on how to write release notes. The bot will check your release
notes automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
* diffgeom
  * Implemented \_\_add__ method for BaseVectorField and Differential
<!-- END RELEASE NOTES -->

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sympy.diffgeom and Add class
2 participants