TensMul: ensure that coeff*nocoeff == self #26476
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief description of what is fixed or changed
Earlier, if
doit
had not been called on a TensMul, self.coeff would be set to 1, while self.nocoeff would unconditionally drop the non-tensor arguments. This PR ensures that even if doit has not been called, we haveself.coeff * self.nocoeff == self
Other comments
I have added a test.
Release Notes
A
, ensure thatA.coeff*A.nocoeff == A
is always true.