Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport: Fix the _array_ methods to avoid deprecation warnings #26456

Merged
merged 9 commits into from
Apr 4, 2024

Conversation

oscarbenjamin
Copy link
Contributor

References to other Issues or PRs

Backport of gh-26442

Brief description of what is fixed or changed

Other comments

Release Notes

  • matrices
    • The Matrix.__array__ method now takes a copy argument since not doing so it deprecated in NumPy 2.0.

RajSapale04 and others added 8 commits April 4, 2024 13:59
   def __array__(self, dtype=object, copy=None):
        if copy is not None and not copy:
            raise TypeError("Cannot implement copy=False when converting Matrix to ndarray")
Currently copy=False is commented out due to a bug
in numpy. see:
numpy/numpy#25941 (comment)
also, fixed a little bug in test_matexpr which was
causing the test to fail on master.
@sympy-bot
Copy link

Hi, I am the SymPy bot. I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.12.1.

Click here to see the pull request description that was parsed.
<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234" (see
https://tinyurl.com/auto-closing for more information). Also, please
write a comment on that issue linking back to this pull request once it is
open. -->

Backport of gh-26442


#### Brief description of what is fixed or changed


#### Other comments


#### Release Notes

<!-- Write the release notes for this release below between the BEGIN and END
statements. The basic format is a bulleted list with the name of the subpackage
and the release note for this PR. For example:

* solvers
  * Added a new solver for logarithmic equations.

* functions
  * Fixed a bug with log of integers. Formerly, `log(-x)` incorrectly gave `-log(x)`.

* physics.units
  * Corrected a semantical error in the conversion between volt and statvolt which
    reported the volt as being larger than the statvolt.

or if no release note(s) should be included use:

NO ENTRY

See https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more
information on how to write release notes. The bot will check your release
notes automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
* matrices
   * The `Matrix.__array__` method now takes a copy argument since not doing so it deprecated in NumPy 2.0.
<!-- END RELEASE NOTES -->

Copy link

github-actions bot commented Apr 4, 2024

Benchmark results from GitHub Actions

Lower numbers are good, higher numbers are bad. A ratio less than 1
means a speed up and greater than 1 means a slowdown. Green lines
beginning with + are slowdowns (the PR is slower then master or
master is slower than the previous release). Red lines beginning
with - are speedups.

Significantly changed benchmark results (PR vs master)

· Did not find results for commit upstream/master

Significantly changed benchmark results (master vs previous release)

       before           after         ratio
     [41d90958]       [40e55587]
     <sympy-1.11.1^0>                 
-         762±3μs          468±2μs     0.61  solve.TimeSparseSystem.time_linear_eq_to_matrix(10)
-        2.14±0ms          872±4μs     0.41  solve.TimeSparseSystem.time_linear_eq_to_matrix(20)
-     4.25±0.01ms      1.28±0.01ms     0.30  solve.TimeSparseSystem.time_linear_eq_to_matrix(30)

Full benchmark results can be found as artifacts in GitHub Actions
(click on checks at the top of the PR).

@oscarbenjamin oscarbenjamin merged commit 2487dbb into sympy:1.12 Apr 4, 2024
70 checks passed
@sympy-bot
Copy link

🚨🚨🚨ERROR🚨🚨🚨 There was an error automatically updating the release notes. Normally it should not have been possible to merge this pull request. You might want to open an issue about this at https://github.com/sympy/sympy-bot/issues.

In the meantime, you will need to update the release notes on the wiki manually.

The error message was: Not all changelog entries were added. Make sure there is a header called ## Authors at the end of the release notes.

@oscarbenjamin oscarbenjamin deleted the pr_array_copy_112 branch April 4, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants