Added test case regarding failure of series/limit unless the expression is simplified #20674
Conversation
Initially the issue was the failure of series/limit unless the expression is simplified first, but it is resoved in current master. So I have added test case addressing this one.
|
✅ Hi, I am the SymPy bot (v161). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.
Click here to see the pull request description that was parsed. |
|
@czgdp1807 Can you please guide me with this pull request what next to be done so that all checks will pass |
|
@Shardul555 your file contains trailing whitespaces |
…on is simplified Added the test case regarding failure of series/limit unless the expression is simplified. It is improvement on last commit as last one had unnecessary whitespaces.
sympy/series/tests/test_series.py
Outdated
| @@ -202,6 +202,13 @@ def test_issue_9549(): | |||
| assert series(y, x, oo) == x**(-5) - 1/x**4 + x**(-3) + 1/x + O(x**(-6), (x, oo)) | |||
|
|
|||
|
|
|||
| def test_issue_9173(): | |||
| var('p_0 p_1 p_2 p_3 b_0 b_1 b_2') | |||
There was a problem hiding this comment.
You are not storing them in variables which you are using, that's why test is failing.
There was a problem hiding this comment.
Thanks for guidance @sidhu1012
…ified This pull request will add the test case regarding failure of series problem until th the expression is simplified using .simplify() function.
sympy/series/tests/test_series.py
Outdated
| @@ -202,6 +202,14 @@ def test_issue_9549(): | |||
| assert series(y, x, oo) == x**(-5) - 1/x**4 + x**(-3) + 1/x + O(x**(-6), (x, oo)) | |||
|
|
|||
|
|
|||
| def test_issue_9173(): | |||
| from sympy import var | |||
There was a problem hiding this comment.
Imports should go on top of file.
There was a problem hiding this comment.
Ok I will do it after these checks will be completed.
There was a problem hiding this comment.
And var should not be used in library code.
There was a problem hiding this comment.
Ok thank you @jksuom ,so can you suggest me what to use instead of var or simply where I will find the rules related to uses of variables.
There was a problem hiding this comment.
As used in other tests like test_issue_12791, you can use symbols instead
Shardul555
changed the title
References to other Issues or PRs
#9173
Brief description of what is fixed or changed
Initially the issue was the failure of series/limit unless the expression is simplified first, but it is resoved in current master.
So I have added test case addressing this one.
Release Notes
NO ENTRY