Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deserializing MPFR #2013

Merged
merged 5 commits into from Apr 17, 2024
Merged

Fix deserializing MPFR #2013

merged 5 commits into from Apr 17, 2024

Conversation

isuruf
Copy link
Member

@isuruf isuruf commented Apr 15, 2024

and use make_rcp<T> instead of rcp(new T))

rikardn
rikardn approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@rikardn rikardn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me. An extra star for nicely organized commits 😉

@isuruf isuruf merged commit 85d58bb into symengine:master Apr 17, 2024
35 checks passed
@isuruf isuruf deleted the mpfr_serialize branch April 17, 2024 14:49
@isuruf
Copy link
Member Author

isuruf commented Apr 17, 2024

Thanks for the review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rikardn rikardn rikardn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@isuruf @rikardn