Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make double parsing locale independent (and faster) #1993

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Make double parsing locale independent (and faster) #1993

wants to merge 3 commits into from

Commits on Feb 20, 2024

  1. Make double parsing locale independent (and faster) 

    - use `std::from_chars` instead of `strtod` to parse doubles if available (c++17 required)
  - otherwise falls back to previous `strtod` implementation
  - `std::from_chars` is locale independent and faster than `strtod`
- add more double parsing tests
- add double parsing google benchmarks
- resolves symengine#1566
    @lkeegan
    lkeegan committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    97a9980 View commit details
    Browse the repository at this point in the history

  2. Remove unnecessary default initialization of result since input strin… 

    …g comes from parser and will always be parsable to a double
    @lkeegan
    lkeegan committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    9c09875 View commit details
    Browse the repository at this point in the history

  3. Use header-only fast_float library instead of std::from_chars due… 

    … to incomplete standard library implementations
    @lkeegan
    lkeegan committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    5189b7b View commit details
    Browse the repository at this point in the history