New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exposed get_base
and get_exp
functions
#1980
Conversation
@isuruf Not sure why some tests fail here. Everything passes for me locally! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can already be achieved by using basic_get_args
right?
Yes, I missed this. I've made the change. |
No, I mean a user could use that method already in the C wrapper and I don't see why we'd need another method to do something similar. |
Okay for some context, Ondrej and I would be adding support for some methods through the Cwrapper for addressing this TODO lcompilers/lpython#2332 |
Also could you educate me regarding the failing tests ? |
I think we should be designing the Symbolic API to be consistent, and I think we have done a lot of this work in SymEngine already. In particular, I think it's cleaner to access the arguments using Regarding the failing tests, not sure what is causing it, you would need to debug it locally. |
I think we can close this one. If you think we need it, you can reopen it. |
Sure if we can do without creating these then let's try it out. I just thought of introducing some consistency with sympy but I think we can do without it ! |
LPython adds the consistency with SymPy. In SymEngine I think we should strive for a minimal C++ and C API, without duplication. |
No description provided.